View property "layout" is protected, so use setLayout() instead.#1046
Closed
alain-guidon wants to merge 1 commit intocakephp:5.xfrom
Closed
View property "layout" is protected, so use setLayout() instead.#1046alain-guidon wants to merge 1 commit intocakephp:5.xfrom
alain-guidon wants to merge 1 commit intocakephp:5.xfrom
Conversation
dereuromark
reviewed
Jun 27, 2025
| use Cake\Core\Configure; | ||
|
|
||
| $this->layout = 'error'; | ||
| $this->setLayout('error'); |
Member
There was a problem hiding this comment.
Protected means outside $this context.
But all of the template are running inside, see also the docblock above :)
So none of those changes are necessary.
Author
There was a problem hiding this comment.
Yes... You're right. :-)
I followed the advice given by the code analyzer (VSCode + DEVSENSE PHP) without thinking about the context.
Sorry.
Member
There was a problem hiding this comment.
If they report this despite the docblock at the top, maybe you can open a bug ticket with them instead.
Author
There was a problem hiding this comment.
Yeap.
You should close this pull request.
Thanks for your replies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.